Skip to content

feat(go): use GenkitError instead of regular error #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
May 1, 2025
Merged

feat(go): use GenkitError instead of regular error #2643

merged 30 commits into from
May 1, 2025

Conversation

sahdev77
Copy link
Contributor

@sahdev77 sahdev77 commented Apr 4, 2025 •
edited
Loading

Addition of new Genkit error in go:

  • Handling Error using Genkit Error.
  • Removal of HTTPError from misc.
    Resolving : 2476
    Checklist (if applicable):
  • PR title is following https://www.conventionalcommits.org/en/v1.0.0/
  • Tested (manually, unit tested, etc.)
  • Docs updated (updated docs or a docs bug required)

@github-actions github-actions bot added the go label Apr 4, 2025
@pavelgj pavelgj requested a review from apascal07 April 7, 2025 12:45
@sahdev77 sahdev77 changed the title Improve errors throughout feat(go): Handling of Errors in go with GenkitError Apr 7, 2025
@sahdev77 sahdev77 marked this pull request as ready for review April 8, 2025 14:49
@apascal07 apascal07 changed the title feat(go): Handling of Errors in go with GenkitError feat(go): use GenkitError instead of regular error Apr 15, 2025
apascal07
apascal07 reviewed Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify a sample to return errors in various places and verify in the Dev UI that the errors look correct and have a useful stack? Conversely, the stack should not appear when calling the prod server, only the reflection server.

@sahdev77 sahdev77 requested a review from apascal07 April 16, 2025 17:54
apascal07
apascal07 reviewed Apr 28, 2025
View reviewed changes
apascal07
apascal07 reviewed Apr 28, 2025
View reviewed changes
apascal07
apascal07 reviewed Apr 28, 2025
View reviewed changes
@sahdev77 sahdev77 requested a review from apascal07 April 29, 2025 18:48
@apascal07 apascal07 enabled auto-merge (squash) May 1, 2025 20:32
@apascal07 apascal07 merged commit e3ad4b4 into main May 1, 2025
7 checks passed
@apascal07 apascal07 deleted the sahdev/go-generic-errors branch May 1, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apascal07 apascal07 apascal07 approved these changes

Assignees
No one assigned
Labels
go tooling
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahdev77 @apascal07